Deflake realtime handoff steering test#28300
Merged
Merged
Conversation
Contributor
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
aibrahim-oai
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details:
Failures in samples seem to be caused by:
The PR changes only step 2: for this test, the mock websocket stays open after sending the scripted handoff event. The same handoff event is still sent, and the test still asserts the important steering behavior:
Validation
just fmtjust test -p codex-core --test all suite::realtime_conversation::inbound_handoff_request_steers_active_turnRecent CI failures with the same signature
https://github.com/openai/codex/actions/runs/27538033492/job/81392362858
[codex] update multi-agent v2 promptsconversation.handoff.requested; websocket read failed withos error 10053https://github.com/openai/codex/actions/runs/27543877820/job/81412200651
feat: dispatch queued user messages through core idle extensionsos error 10054https://github.com/openai/codex/actions/runs/27544342375/job/81413801641
[codex] Make marketplace loading capability awareos error 10053