[codex] reuse encoded Responses request bodies - #28324
Closed
jif-oai wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Replaced by #28327, opened directly from an openai/codex branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Responses HTTP requests were converted from
ResponsesApiRequestinto a fullserde_json::Value.EndpointSessionthen deep-cloned that value for each retry, and the transport serialized and compressed it again before every send.Large histories make those copies expensive. Retry attempts should reuse the same immutable request bytes.
What
EncodedJsonBody.Bytesreference count.Valuepath.Performance
A temporary release-mode measurement used a 10 MiB JSON body and 10 retry preparations:
Valueclone + serialize path: 30 ms totalThat is about 3 ms avoided per retry for this payload on the test machine. Each retry also stops allocating another request-sized JSON tree and serialized buffer. Without TRACE, compressed requests retain only the final compressed wire bytes.
Validation
just test -p codex-client— 28 passedjust test -p codex-api— 125 passedjust fix -p codex-clientjust fix -p codex-api