Skip to content

skills: hide orchestrator skills with a local executor#28333

Merged
jif-oai merged 1 commit into
mainfrom
jif/nit-remote-orch
Jun 15, 2026
Merged

skills: hide orchestrator skills with a local executor#28333
jif-oai merged 1 commit into
mainfrom
jif/nit-remote-orch

Conversation

@jif-oai

@jif-oai jif-oai commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Why

App-server threads without a local executor need orchestrator-owned skills from the hosted codex_apps MCP server. Threads with the local executor already discover installed skills from the local filesystem.

After the orchestrator skill provider was enabled for every app-server thread, local-executor threads also received the hosted skill catalog and the skills.list and skills.read tools. This changed the existing local behavior and could expose a second hosted copy of a skill that was already installed locally.

What changed

  • Expose the thread's selected execution environments to extensions at thread startup.
  • Enable orchestrator skills only when the reserved local environment is not selected.
  • Apply that decision consistently to hosted skill catalog discovery, explicit skill injection, and the skills.list and skills.read tools.

Verification

  • The existing no-executor app-server test continues to verify hosted skill discovery, invocation, and child-resource reads.
  • A new app-server test verifies that local-executor threads do not receive hosted skill context or skills.* tools.

@jif-oai
jif-oai requested a review from a team as a code owner June 15, 2026 15:05
@jif-oai jif-oai changed the title remote skills for orchestrator only skills: hide orchestrator skills with a local executor Jun 15, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 872e4d5152

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/ext/skills/src/extension.rs
@jif-oai
jif-oai merged commit 6d9df68 into main Jun 15, 2026
30 checks passed
@jif-oai
jif-oai deleted the jif/nit-remote-orch branch June 15, 2026 15:15
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant