Extract shared Windows sandbox session runner#28357
Merged
Merged
Conversation
pakrym-oai
approved these changes
Jun 15, 2026
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 328cff02bf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
iceweasel-oai
enabled auto-merge (squash)
June 15, 2026 18:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This is the first PR in a stack for the Windows fs-helper sandbox fix. Before changing fs-helper behavior, this pulls the reusable Windows sandbox session launch pieces out of the debug CLI path so later PRs can call the same backend selection and stdio forwarding logic.
Keeping this as a pure refactor makes the later security fix easier to review:
codex sandbox windowsshould continue to launch the same elevated or restricted-token backend, just through shared APIs inwindows-sandbox-rsinstead of code local tocli/src/debug_sandbox.rs.What Changed
WindowsSandboxSessionRequestandspawn_windows_sandbox_session_for_level()inwindows-sandbox-rsto share the elevated-vs-legacy session launch decision.cli/src/debug_sandbox.rsintowindows-sandbox-rs/src/stdio_bridge.rs.codex sandbox windowsto call the shared session launcher and stdio bridge.Verification
just bazel-lock-updatejust bazel-lock-checkjust test -p codex-windows-sandbox stdio_bridge::testsjust fix -p codex-windows-sandbox -p codex-sandboxing -p codex-exec-server -p codex-arg0 -p codex-core -p codex-file-systemstdio_bridgetests also passed as part ofjust test -p codex-windows-sandboxon the stack tip. That full local run still fails in pre-existing legacy session integration tests withCreateRestrictedToken failed: 87on this workstation.