[codex] Fix missing response item metadata in tests#28415
Merged
Conversation
adaley-openai
marked this pull request as ready for review
June 15, 2026 23:54
pakrym-oai
approved these changes
Jun 15, 2026
adaley-openai
enabled auto-merge (squash)
June 15, 2026 23:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
metadata: Noneinitializers after feat(core): add metadata field to ResponseItem #28355 made response-item metadata required.codex-coreandcodex-apion main.Validation
git diff --checkjust fmt(Rust formatting passed; unrelated Python formatter steps could not use the sandboxed shareduvcache)just test -p codex-core guardian_review_request_layout_matches_model_visible_request_snapshotjust test -p codex-api responses_client_stream_request_preserves_exact_json_body