[codex] Warn clearly when code mode output is truncated#28467
Merged
Conversation
aibrahim-oai
force-pushed
the
codex/warn-on-truncated-output
branch
from
June 16, 2026 06:44
abfbc54 to
e836c4a
Compare
aibrahim-oai
changed the base branch from
main
to
codex/fix-code-mode-output-budgets
June 16, 2026 06:45
aibrahim-oai
force-pushed
the
codex/warn-on-truncated-output
branch
from
June 16, 2026 15:42
e836c4a to
7a2b050
Compare
aibrahim-oai
changed the base branch from
codex/fix-code-mode-output-budgets
to
main
June 16, 2026 15:42
aibrahim-oai
force-pushed
the
codex/warn-on-truncated-output
branch
from
June 16, 2026 15:48
7a2b050 to
f35b6f7
Compare
aibrahim-oai
marked this pull request as ready for review
June 16, 2026 15:57
aibrahim-oai
force-pushed
the
codex/warn-on-truncated-output
branch
from
June 16, 2026 16:03
f35b6f7 to
cd5d2e5
Compare
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f35b6f7dca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
Author
|
@codex review |
pakrym-oai
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
formatted_truncate_textprependWarning: truncated output (original token count: N)above the existingTotal output linesheaderValidation
cargo test -p codex-utils-output-truncation -- --nocapture(17 passed)cargo test -p codex-core --lib truncated_text_output_starts_with_warning -- --nocapturecargo test -p codex-core --test all clamps_model_requested_max_output_tokens_to_policy -- --nocapture(2 passed)cargo test -p codex-core --test all unified_exec_formats_large_output_summary -- --nocapturecargo test -p codex-core --test all user_shell_command_output_is_truncated_in_history -- --nocapture