[codex] Clarify plugin load and runtime capability stages#28472
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c86d41dda6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| vec![AppConnectorId("connector_sample".to_string())] | ||
| ); | ||
| assert_eq!( | ||
| chatgpt_outcome.capability_summaries(), |
There was a problem hiding this comment.
Runtime plugin capability projection now changes after auth switches, but the only new check is a unit test. Repo guidance requires integration coverage for agent-logic changes, so please add a core integration test or explain why no user-facing behavior needs one. guidance
Useful? React with 👍 / 👎.
2 participants
Summary
Plugin loading and auth projection both previously produced
PluginLoadOutcome. That made an unfiltered load result look like runtime-ready capabilities and generated capability summaries before auth routing had run.This change keeps loaded plugin records in the cache, applies the current auth policy in
PluginsManager, and only then buildsPluginLoadOutcomeand its summaries. Auth changes still reuse the cached disk load and re-resolve apps and MCP servers without reloading plugins.The updated tests cover cached auth changes and verify that capability summaries match the effective app/MCP surface.
Testing
just test -p codex-core-pluginsjust test -p codex-pluginjust fix -p codex-core-plugins