Skip to content

path-uri: clarify invalid host path errors#28473

Merged
anp-oai merged 3 commits into
mainfrom
codex/path-uri-invalid-os-error
Jun 16, 2026
Merged

path-uri: clarify invalid host path errors#28473
anp-oai merged 3 commits into
mainfrom
codex/path-uri-invalid-os-error

Conversation

@anp-oai

@anp-oai anp-oai commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Why

Ensure a consistent string format when exposing path conversion errors to the model.

What

  • Render PathUriParseError::InvalidFileUriPath as '$PATH' is invalid on '$OS'.

Comment thread codex-rs/exec-server/src/fs_sandbox.rs Outdated
@anp-oai
anp-oai marked this pull request as ready for review June 16, 2026 07:03
@anp-oai
anp-oai requested a review from a team as a code owner June 16, 2026 07:03
@anp-oai

anp-oai commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. 👍

Reviewed commit: 7c8492f67b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@anp-oai
anp-oai merged commit 7162030 into main Jun 16, 2026
46 of 47 checks passed
@anp-oai
anp-oai deleted the codex/path-uri-invalid-os-error branch June 16, 2026 16:03
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants