Skip to content

Resume exec-server sessions after disconnect #28512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jif-oai merged 4 commits into from
Jun 17, 2026
Merged

Resume exec-server sessions after disconnect #28512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d221479
Resume exec-server sessions after disconnect
jif-oai Jun 16, 2026
53ddb4d
Drain notifications during explicit resume
jif-oai Jun 16, 2026
aa2dfb4
fix everything
jif-oai Jun 16, 2026
447d8fb
Merge branch 'main' into jif/automatic-exec-session-recovery
jif-oai Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
660 changes: 408 additions & 252 deletions codex-rs/exec-server/src/client.rs
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 5 additions & 1 deletion codex-rs/exec-server/src/client/rpc_http_client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ impl ExecServerClient {
&self,
mut params: HttpRequestParams,
) -> Result<(HttpRequestResponse, HttpResponseBodyStream), ExecServerError> {
let rpc_client = self.inner.rpc_client().await?;
params.stream_response = true;
let request_id = self.inner.next_http_body_stream_request_id();
params.request_id = request_id.clone();
Expand All @@ -51,7 +52,10 @@ impl ExecServerClient {
.await?;
let mut registration =
HttpBodyStreamRegistration::new(Arc::clone(&self.inner), request_id.clone());
let response = match self.call(HTTP_REQUEST_METHOD, &params).await {
let response = match self
.call_rpc(&rpc_client, HTTP_REQUEST_METHOD, &params)
.await
{
Ok(response) => response,
Err(error) => {
self.inner.remove_http_body_stream(&request_id).await;
Expand Down
Loading
Loading