Skip to content

Add join key for MAv2 inter-agent messages#28561

Merged
jif-oai merged 6 commits into
mainfrom
jif/app-server-inter-agent-items
Jun 17, 2026
Merged

Add join key for MAv2 inter-agent messages#28561
jif-oai merged 6 commits into
mainfrom
jif/app-server-inter-agent-items

Conversation

@jif-oai

@jif-oai jif-oai commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

This keeps inter-agent communication on the existing raw response item path and adds a join key for MAv2 tool calls.

MAv2 spawn_agent, send_message, and followup_task now stamp the originating tool call id into ResponseItemMetadata.source_call_id on the raw ResponseItem::AgentMessage. App-server clients can join that raw item back to the existing tool/activity event by call id, while using the raw agent message's existing sender, receiver, and content fields.

No new app-server ThreadItem or notification type is added.

Tests

  • just fmt
  • just write-app-server-schema
  • just test -p codex-protocol
  • just test -p codex-app-server-protocol
  • just test -p codex-core multi_agent_v2_spawn_returns_path_and_send_message_accepts_relative_path
  • just test -p codex-core multi_agent_v2_followup_task_completion_notifies_parent_on_every_turn
  • just fix -p codex-protocol
  • just fix -p codex-app-server-protocol
  • just fix -p codex-core

@jif-oai jif-oai requested a review from a team as a code owner June 16, 2026 17:40

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 854ae7eec0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core/src/session/mod.rs Outdated
Comment thread codex-rs/core/src/tools/handlers/multi_agents_v2/message_tool.rs
Comment thread codex-rs/core/src/session/mod.rs Outdated
Comment thread codex-rs/app-server-protocol/src/protocol/v2/item.rs Outdated
@jif-oai jif-oai changed the title Expose inter-agent communications as app-server items Add join key for MAv2 inter-agent messages Jun 16, 2026
@jif-oai

jif-oai commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: add04908ce

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/protocol/src/models.rs
Comment thread codex-rs/core/src/tools/handlers/multi_agents_v2/spawn.rs
@jif-oai

jif-oai commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator Author

@codex reviewe

@jif-oai jif-oai merged commit 45f6033 into main Jun 17, 2026
31 checks passed
@jif-oai jif-oai deleted the jif/app-server-inter-agent-items branch June 17, 2026 12:48
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants