[codex] Pass plugin namespace into skill loading#28608
Merged
Merged
Conversation
xl-openai
approved these changes
Jun 18, 2026
mzeng-openai
force-pushed
the
dev/mzeng/pass-plugin-skill-namespace
branch
from
3c13af5 to
8ccb4cf
Compare
mzeng-openai
force-pushed
the
dev/mzeng/pass-plugin-skill-namespace
branch
from
8ccb4cf to
bb0c68f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
PluginSkillRootandSkillRootWhy
Plugin loading has already parsed
plugin.json, but skill parsing currently walks everySKILL.mdancestor and probes/reads the manifest again to reconstruct the same namespace. Passing the parsed namespace removes those repeated filesystem calls, which are particularly costly on remote filesystems.Context: https://openai.slack.com/archives/C0ARA9GF5D4/p1781639496496439?thread_ts=1781202444.891669&cid=C0ARA9GF5D4
Impact
Plugin skill names remain unchanged. A regression test uses a deliberately different on-disk manifest name to verify that plugin roots use the provided parsed namespace.
Validation
just test -p codex-core-skills -p codex-core-plugins -p codex-plugin -p codex-utils-plugins(352 passed)just fix -p codex-core-skills -p codex-core-plugins -p codex-plugin -p codex-utils-pluginsjust fmt