Skip to content

[codex] Load plugins and skill roots concurrently#28624

Open
mzeng-openai wants to merge 2 commits into
dev/mzeng/reuse-plugin-skill-root-snapshotsfrom
dev/mzeng/load-plugin-skills-concurrently
Open

[codex] Load plugins and skill roots concurrently#28624
mzeng-openai wants to merge 2 commits into
dev/mzeng/reuse-plugin-skill-root-snapshotsfrom
dev/mzeng/load-plugin-skills-concurrently

Conversation

@mzeng-openai

@mzeng-openai mzeng-openai commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Why

Configured plugins and skill roots are independent reads, but the cold startup path loads them serially. Bounded concurrency reduces that latency without allowing one large catalog to create unbounded filesystem work.

What changed

  • load up to eight configured plugins concurrently
  • scan up to eight skill roots concurrently through the shared PluginSkillRootCache
  • use order-preserving buffering so configured-plugin order, root priority, deduplication, and warning resolution remain deterministic
  • box the bounded worker futures so downstream spawned session futures remain compiler-tractable
  • add coverage that configured plugin results remain sorted

This is stacked on #28623, which introduces the shared plugin skill-root cache used by this change.

Validation

  • just test -p codex-core-skills -p codex-core-plugins (359 passed)
  • just fix -p codex-core-skills -p codex-core-plugins
  • just bazel-lock-check

@mzeng-openai mzeng-openai force-pushed the dev/mzeng/reuse-plugin-skill-root-snapshots branch from fee6592 to a0874b0 Compare June 17, 2026 00:30
@mzeng-openai mzeng-openai force-pushed the dev/mzeng/load-plugin-skills-concurrently branch from 743e2c8 to 303e141 Compare June 17, 2026 01:35
@mzeng-openai mzeng-openai marked this pull request as ready for review June 17, 2026 01:59
@mzeng-openai mzeng-openai force-pushed the dev/mzeng/reuse-plugin-skill-root-snapshots branch from a0874b0 to 615d3a5 Compare June 18, 2026 05:08
@mzeng-openai mzeng-openai requested a review from a team as a code owner June 18, 2026 05:08
@mzeng-openai mzeng-openai force-pushed the dev/mzeng/load-plugin-skills-concurrently branch from 8e6a542 to 742d2cb Compare June 18, 2026 05:10
@mzeng-openai mzeng-openai force-pushed the dev/mzeng/reuse-plugin-skill-root-snapshots branch from 615d3a5 to d81821e Compare June 18, 2026 05:18
@mzeng-openai mzeng-openai force-pushed the dev/mzeng/load-plugin-skills-concurrently branch 2 times, most recently from 5982b32 to 4cd8e2e Compare June 18, 2026 05:53
@mzeng-openai mzeng-openai force-pushed the dev/mzeng/reuse-plugin-skill-root-snapshots branch from d1fbda5 to 31491e4 Compare June 18, 2026 07:25
@mzeng-openai mzeng-openai force-pushed the dev/mzeng/load-plugin-skills-concurrently branch from 4cd8e2e to 8c52fda Compare June 18, 2026 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants