Skip to content

[codex] Gate remote plugin catalog by auth#28625

Merged
xl-openai merged 1 commit into
mainfrom
xl/plugin-bug
Jun 17, 2026
Merged

[codex] Gate remote plugin catalog by auth#28625
xl-openai merged 1 commit into
mainfrom
xl/plugin-bug

Conversation

@xl-openai

Copy link
Copy Markdown
Contributor

Summary

  • Treat the remote global plugin catalog as active only when remote_plugin is enabled and the current auth uses the Codex backend.
  • Skip the local OpenAI curated marketplace for remote-enabled ChatGPT users while preserving configured marketplaces.
  • Keep the local curated marketplace for API-key users, unauthenticated fallback, and ChatGPT users with remote_plugin disabled.
  • Apply the same effective-remote gate to the remote installed-marketplace cache.

Root cause

The tool-suggestion discovery path unconditionally included the local OpenAI curated marketplace. For remote-enabled ChatGPT users, that made remote discovery additive: Codex parsed every local curated plugin.json before also loading the remote catalog.

Validation

  • just fmt
  • cargo build -p codex-cli --bin codex
  • Targeted auth/feature matrix tests pass, including API-key auth with remote_plugin enabled.
  • Manual CLI validation confirmed:
    • ChatGPT + remote off includes local curated.
    • ChatGPT + remote on excludes local curated.
    • API-key auth keeps local curated when remote is enabled.
  • just test -p codex-core-plugins: 235 passed; one unrelated existing marketplace test failed because it loaded the developer's home marketplace configuration.

@xl-openai
xl-openai marked this pull request as ready for review June 16, 2026 23:41
@xl-openai
xl-openai merged commit 69bc064 into main Jun 17, 2026
45 of 47 checks passed
@xl-openai
xl-openai deleted the xl/plugin-bug branch June 17, 2026 00:24
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants