[codex] Repair invalid skill frontmatter scalars#28628
Merged
charlesgong-openai merged 2 commits intoJun 17, 2026
Merged
Conversation
charlesgong-openai
marked this pull request as ready for review
June 17, 2026 00:36
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8e13ee371f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
xl-openai
approved these changes
Jun 17, 2026
charlesgong-openai
deleted the
dev/charlesgong/fix-skill-description-colon-yaml
branch
June 17, 2026 17:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The community marketplace audit found many skill frontmatter parse failures where values were intended as prose, but were not valid YAML. Common examples include unquoted scalar values with
:, such asdescription: Build for AWS: ECSorargument-hint: <duration: e.g. 7d>, and flow-looking values such astags: [next,@supabase/ssr].serde_yamldoes not expose a permissive mode for this. The parser fails before unknown frontmatter fields can be ignored, so a compatibility repair has to happen before retrying YAML parsing.What changed
Skill frontmatter loading still uses
serde_yamlas the primary parser. If that parse fails, the loader performs a line-oriented repair of scalar frontmatter field values, then retries parsing.The fallback now:
description/short-description:[,{,@, or backtick|/>block scalar bodies so multiline descriptions are not rewrittenExamples
This previously failed because the second
:was parsed as YAML structure:The fallback now parses it as if it had been written explicitly as:
The same repair now applies to ignored frontmatter fields that still need to be valid YAML for the parser to get through the document:
Valid YAML multiline descriptions continue to work through normal parsing without repair:
Validation
descriptionvalues containing:.metadata.short-descriptionvalues containing:and an apostrophe.argument-hintandtags.just test -p codex-core-skills(106 passed)just fix -p codex-core-skills