Skip to content

Revert thread recencyAt for sidebar ordering#28655

Merged
pakrym-oai merged 1 commit into
mainfrom
pakrym/revert-thread-recency
Jun 17, 2026
Merged

Revert thread recencyAt for sidebar ordering#28655
pakrym-oai merged 1 commit into
mainfrom
pakrym/revert-thread-recency

Conversation

@pakrym-oai

Copy link
Copy Markdown
Contributor

Why

Revert #27910 to remove the newly introduced thread recencyAt persistence and API behavior from main.

What changed

This reverts commit fac3158c2a783095768076489815f361fa9b0db4, including the state migration, thread-store propagation, app-server API surface, generated schemas, and related tests.

Validation

Not run before opening; relying on CI for the initial fast signal.

@pakrym-oai
pakrym-oai requested a review from a team as a code owner June 17, 2026 04:17

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bfbbffc1a9

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@@ -1,28 +0,0 @@
ALTER TABLE threads ADD COLUMN recency_at INTEGER NOT NULL DEFAULT 0;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve applied migration 38 compatibility

If any state DB has already recorded this reverted migration as version 38, deleting it leaves version 38 represented by the different 0038_external_agent_config_imports.sql file; the runtime migrator only ignores missing newer versions and still validates checksums for known versions, so those users will fail state DB migration on startup with a checksum mismatch instead of opening their existing sessions. Please keep a compatibility path for the old version-38 checksum (or otherwise repair/renumber the migration history) before removing this file.

Useful? React with 👍 / 👎.

@pakrym-oai
pakrym-oai merged commit cb15c64 into main Jun 17, 2026
45 of 47 checks passed
@pakrym-oai
pakrym-oai deleted the pakrym/revert-thread-recency branch June 17, 2026 04:39
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants