[codex] Persist built-in image results reported as generating#28656
Merged
Conversation
won-openai
marked this pull request as ready for review
June 17, 2026 05:03
sayan-oai
approved these changes
Jun 17, 2026
won-openai
enabled auto-merge (squash)
June 17, 2026 05:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#27920 stopped persisting image-generation items unless their status was
completed, preventing failed standalone extension items with empty results from being saved. Built-in image generation can instead emit a terminalresponse.output_item.donecontaining a complete base64 PNG while the item status remainsgenerating. In that case, app-server emits nosavedPath, so Codex Apps can render the inline image but cannot expose a file artifact.What changed
resultcontains image data. Failed terminal items still have empty results and remain unpersisted.generatingitem and verify bothsaved_pathand the written PNG bytes.Validation
in_progress,generating, andpartial_image, then emitted oneresponse.output_item.donewithstatus: "generating"and a complete PNG result.just test -p codex-core builtin_image_generation_call_persistedis currently blocked before test execution by a pre-existing compile error inthread-store/src/thread_metadata_sync.rs:171.