app-server: keep the model cache warm#28699
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e76d6a83fa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
aibrahim-oai
approved these changes
Jun 17, 2026
jif-oai
force-pushed
the
jif/keep-model-hot
branch
from
June 17, 2026 13:04
8b7d9ab to
eb8f8e8
Compare
Contributor
Author
|
@codex review |
jif-oai
force-pushed
the
jif/keep-model-hot
branch
from
June 17, 2026 13:20
eb8f8e8 to
35e5d6b
Compare
jif-oai
force-pushed
the
jif/keep-model-hot
branch
from
June 17, 2026 13:39
35e5d6b to
8d81430
Compare
jif-oai
enabled auto-merge (squash)
June 17, 2026 13:47
jif-oai
disabled auto-merge
June 17, 2026 14:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The app server is long-lived, but its shared model cache otherwise refreshes only when a caller needs it. Once the five-minute cache expires, starting a thread or calling
model/listcan wait for/modelson the request path.Refresh the cache in the background before it expires so foreground callers normally use fresh local state.
What changed
/modelsprobe from the connection they are testing.The existing models-manager cache, refresh strategies, auth handling, ETag behavior, and concurrency semantics are unchanged.
Testing
models_refresh_worker::tests::refreshes_immediately_periodically_and_stops_when_droppedsuite::v2::remote_control::listen_off_honors_persisted_remote_control_enablesuite::v2::attestation::attestation_generate_round_trip_adds_header_to_responses_websocket_handshake