Skip to content

[codex] Track plugin install and import telemetry failures#28731

Merged
charlesgong-openai merged 10 commits into
mainfrom
dev/charlesgong/track-plugin-import-analytics
Jun 17, 2026
Merged

[codex] Track plugin install and import telemetry failures#28731
charlesgong-openai merged 10 commits into
mainfrom
dev/charlesgong/track-plugin-import-analytics

Conversation

@charlesgong-openai

@charlesgong-openai charlesgong-openai commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Track plugin install failures through the unified codex_plugin_install_failed event for local installs, remote install preflight failures, bundle failures, and remote catalog/backend failures.
  • Send classified error_type values in plugin install failure analytics instead of raw error strings.
  • Stop sending raw external-agent import errors in analytics while preserving raw failure details in app-facing import notifications/history.
  • Keep raw plugin/migration diagnostics in tracing::warn! logs.
  • Keep remote failure plugin names as the existing local placeholder (unknown) and remove the extra telemetry plugin-name override.
  • Change ExternalAgentConfigImportParams.source from a generated enum to string | null, with legacy claudeCode / claudeCowork inputs normalized to existing analytics values.

Testing

@charlesgong-openai
charlesgong-openai marked this pull request as ready for review June 17, 2026 17:36

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8abbf3bd59

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/app-server/src/request_processors/external_agent_config_processor.rs Outdated
Comment thread codex-rs/app-server/src/request_processors/external_agent_config_processor.rs Outdated
@charlesgong-openai
charlesgong-openai merged commit 3959ab0 into main Jun 17, 2026
46 of 47 checks passed
@charlesgong-openai
charlesgong-openai deleted the dev/charlesgong/track-plugin-import-analytics branch June 17, 2026 20:16
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants