Scope command approvals by execution environment#28738
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 73f26f349a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
73f26f3 to
7761604
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Why
Command approval cache keys included the command and working directory, but not the execution environment. An approval for
/workspacelocally could therefore be reused for the same command and path on an executor.What changed
environmentIdand show it in the inline TUI approval prompt.For example,
echo okin local/workspaceandecho okin executor/workspacenow produce different approval keys and separate prompts.Scope
This PR does not change network approvals, Guardian review actions, MCP elicitation, full-screen TUI rendering, or environment-ID validation. Remote
shell_commandexecution itself remains in #28722; this PR only makes its approval key environment-aware.