Skip to content

Add network environment ID plumbing#28766

Merged
jif-oai merged 1 commit into
mainfrom
jif/scope-network-approvals-by-environment
Jun 18, 2026
Merged

Add network environment ID plumbing#28766
jif-oai merged 1 commit into
mainfrom
jif/scope-network-approvals-by-environment

Conversation

@jif-oai

@jif-oai jif-oai commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Why

Prepare network approval scoping to distinguish execution environments without changing behavior yet.

What changed

  • Add optional environment IDs to network policy requests.
  • Add optional network environment IDs to exec and sandbox request structs.
  • Thread default None values through existing construction points.
  • Fix stale constructor call sites that caused the CI compile failures.

Not included

  • Per-environment proxy listeners.
  • Network approval cache or prompt behavior changes.
  • Ambiguous request attribution handling.

Those behavior changes moved to stacked follow-up #28899.

Validation

  • just fmt
  • CI will run tests and clippy

@jif-oai jif-oai requested a review from a team as a code owner June 17, 2026 18:03

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 788c72d583

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core/src/tools/network_approval_tests.rs Outdated
Comment thread codex-rs/core/src/tools/network_approval.rs Outdated
Comment thread codex-rs/core/src/tools/network_approval.rs Outdated
@jif-oai

jif-oai commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 98a6552227

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core/src/tools/network_approval.rs Outdated
Comment thread codex-rs/core/src/tools/runtimes/shell.rs Outdated
Comment thread codex-rs/network-proxy/src/proxy.rs Outdated
@jif-oai jif-oai force-pushed the jif/scope-network-approvals-by-environment branch from 3b4fb99 to 2ff87c1 Compare June 18, 2026 10:01
@jif-oai jif-oai changed the title Scope network approvals by execution environment Add network environment ID plumbing Jun 18, 2026
@jif-oai

jif-oai commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: 2ff87c1fc4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jif-oai

jif-oai commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator Author

Failure is flake

@jif-oai jif-oai merged commit 0369b24 into main Jun 18, 2026
29 of 31 checks passed
@jif-oai jif-oai deleted the jif/scope-network-approvals-by-environment branch June 18, 2026 12:09
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants