Skip to content

[connectors] Ignore synthetic links for app accessibility#28770

Merged
adaley-openai merged 1 commit into
mainfrom
dev/adaley/ignore-synthetic-links-for-app-accessibility
Jun 18, 2026
Merged

[connectors] Ignore synthetic links for app accessibility#28770
adaley-openai merged 1 commit into
mainfrom
dev/adaley/ignore-synthetic-links-for-app-accessibility

Conversation

@adaley-openai

@adaley-openai adaley-openai commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Stop treating Codex Apps MCP tools with _meta._codex_apps.synthetic_link: true as evidence that a connector is accessible in app/list.
  • Preserve synthetic tools in the agent-facing MCP connector set so they remain available for install/auth flows.
  • Keep the app-list accessibility cache limited to connectors backed by at least one non-synthetic tool.
  • Add focused regression coverage for both sides of the boundary.

Validation

  • just fmt
  • just test -p codex-core synthetic_links_are_exposed_to_the_agent_but_not_accessible_in_app_list
  • git diff --check
  • A crate-wide just test -p codex-core run completed with 2,699 passing and 51 unrelated local sandbox/state failures, primarily state DB migration races (UNIQUE constraint failed: _sqlx_migrations.version).

@adaley-openai adaley-openai force-pushed the dev/adaley/ignore-synthetic-links-for-app-accessibility branch 2 times, most recently from ddeefc5 to ea04b27 Compare June 18, 2026 20:33
@adaley-openai adaley-openai force-pushed the dev/adaley/ignore-synthetic-links-for-app-accessibility branch from ea04b27 to 59da433 Compare June 18, 2026 20:39
@adaley-openai adaley-openai marked this pull request as ready for review June 18, 2026 20:43
@adaley-openai adaley-openai requested a review from a team as a code owner June 18, 2026 20:43
@adaley-openai adaley-openai merged commit 4af7762 into main Jun 18, 2026
31 checks passed
@adaley-openai adaley-openai deleted the dev/adaley/ignore-synthetic-links-for-app-accessibility branch June 18, 2026 21:19
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants