Skip to content

[codex] Support assistant realtime append text#28836

Merged
guinness-oai merged 1 commit into
mainfrom
guinness/realtime-assistant-append-text
Jun 18, 2026
Merged

[codex] Support assistant realtime append text#28836
guinness-oai merged 1 commit into
mainfrom
guinness/realtime-assistant-append-text

Conversation

@guinness-oai

Copy link
Copy Markdown
Collaborator

Why

Frontend realtime voice continuity needs to replay a tiny previous-session overlap as actual conversation items, including assistant text. The app-server thread/realtime/appendText API already carries a role through to the Rust realtime websocket layer, but the shared role enum only accepted user and developer.

What Changed

  • Added assistant to ConversationTextRole and regenerated the app-server schema/type fixtures.
  • Added output_text as a realtime conversation content type.
  • Updated realtime websocket item creation so assistant appendText emits content: [{ type: "output_text", text }], while user and developer continue to emit input_text.
  • Updated app-server docs and tests to cover assistant appendText alongside the existing developer role behavior.

Validation

  • just write-app-server-schema
  • just fmt (first sandboxed attempt failed because uv could not access ~/.cache/uv; reran with filesystem access and passed)
  • just test -p codex-api passed: 126/126
  • just test -p codex-app-server-protocol passed: 239/239, including generated JSON/TypeScript fixture checks
  • just test -p codex-app-server was started locally but stopped per request after unrelated local sandbox/Seatbelt failures (sandbox-exec: sandbox_apply: Operation not permitted) and one missing local codex binary failure; CI should be faster and more authoritative for the full suite.

@guinness-oai

Copy link
Copy Markdown
Collaborator Author

@codex

@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: 943dffb813

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@guinness-oai guinness-oai marked this pull request as ready for review June 18, 2026 03:31
@guinness-oai guinness-oai merged commit e922f46 into main Jun 18, 2026
31 checks passed
@guinness-oai guinness-oai deleted the guinness/realtime-assistant-append-text branch June 18, 2026 03:57
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants