apply-patch: carry paths as PathUri#28854
Merged
Merged
Conversation
anp-oai
force-pushed
the
codex/apply-patch-path-uri
branch
from
4c29479 to
1f21171
Compare
anp-oai
commented
Jun 18, 2026
Collaborator
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
anp-oai
added a commit
that referenced
this pull request
Jun 18, 2026
pakrym-oai
reviewed
Jun 18, 2026
pakrym-oai
approved these changes
Jun 18, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 18, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 18, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 18, 2026
anp-oai
force-pushed
the
codex/apply-patch-path-uri
branch
from
52a32b6 to
566b12f
Compare
anp-oai
added a commit
that referenced
this pull request
Jun 18, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 18, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 18, 2026
anp-oai
force-pushed
the
codex/apply-patch-path-uri
branch
from
566b12f to
647d9ed
Compare
anp-oai
added a commit
that referenced
this pull request
Jun 18, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 18, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 18, 2026
anp-oai
force-pushed
the
codex/apply-patch-path-uri
branch
from
647d9ed to
82e6e0c
Compare
anp-oai
force-pushed
the
codex/apply-patch-path-uri
branch
from
82e6e0c to
d783cdf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Allows the model to edit files that are hosted on a different OS than where app-server is running.
What
PathUrifor apply_patch-internal data structuresPathUri->AbsolutePathBufconversion to cases where the inferred path convention matches the host OS, allows requiring valid paths to pass to perms checkPathConvention::path_segments()for iterating over path segments regardless of OS