Always use AVAS for realtime WebRTC calls#28856
Conversation
…ays-avas-realtime # Conflicts: # codex-rs/app-server-protocol/src/protocol/common.rs # codex-rs/app-server-protocol/src/protocol/v2/realtime.rs # codex-rs/app-server/src/request_processors/turn_processor.rs # codex-rs/app-server/tests/suite/v2/experimental_api.rs # codex-rs/app-server/tests/suite/v2/realtime_conversation.rs # codex-rs/core/tests/suite/compact_remote.rs # codex-rs/core/tests/suite/realtime_conversation.rs # codex-rs/protocol/src/protocol.rs
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 215e59f227
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| fn configure_realtime_call_request(request: &mut Request) { | ||
| append_query_pair(&mut request.url, "intent", "quicksilver"); | ||
| append_query_pair(&mut request.url, "architecture", "avas"); |
There was a problem hiding this comment.
The AVAS query helper is only invoked from the session-backed create_with_session* path, so public callers that use RealtimeCallClient::create()/create_with_headers() still POST raw SDP to /realtime/calls without intent=quicksilver&architecture=avas. If those APIs are used to create WebRTC calls directly, they now bypass the new “WebRTC means AVAS” behavior and keep hitting the old realtime-call route.
Useful? React with 👍 / 👎.
3 participants
Summary
architectureselector from core protocol, app-server protocol, config parsing, generated schemas, and callers.intent=quicksilver&architecture=avas.Notes
[realtime] architecture = "realtimeapi" | "avas"config knob is removed. Local configs that still set it will need to delete that line.Validation
origin/mainat83e6a786a2.just fmtjust write-config-schemajust write-app-server-schemagit diff --checkjust test -p codex-api -p codex-core -p codex-app-server-protocol -p codex-app-server realtime(176 passed)just test -p codex-protocol -p codex-config(413 passed)