[codex] Preserve remote plugin download status errors#28863
Merged
Conversation
xli-oai
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The non-success response path reused the normal size-limited body reader. When an error response exceeded 8 KiB, that reader returned
DownloadTooLargebefore the code constructedDownloadStatus, masking the upstream HTTP status and response context.Impact
Remote plugin installation failures now retain the actionable upstream HTTP status without allowing unbounded error bodies into logs.
Validation
just test -p codex-app-server plugin_install_preserves_status_when_remote_bundle_error_body_is_too_largejust fmtgit diff --check