Skip to content

[codex] Preserve remote plugin download status errors#28863

Merged
xl-openai merged 1 commit into
mainfrom
xl/plguins2
Jun 18, 2026
Merged

[codex] Preserve remote plugin download status errors#28863
xl-openai merged 1 commit into
mainfrom
xl/plguins2

Conversation

@xl-openai

Copy link
Copy Markdown
Collaborator

Summary

  • preserve the original HTTP status when a remote plugin bundle download returns a non-success response
  • retain at most 8 KiB of the error response body and annotate truncation or body-read failures
  • add regression coverage for an oversized error response

Root cause

The non-success response path reused the normal size-limited body reader. When an error response exceeded 8 KiB, that reader returned DownloadTooLarge before the code constructed DownloadStatus, masking the upstream HTTP status and response context.

Impact

Remote plugin installation failures now retain the actionable upstream HTTP status without allowing unbounded error bodies into logs.

Validation

  • just test -p codex-app-server plugin_install_preserves_status_when_remote_bundle_error_body_is_too_large
  • just fmt
  • git diff --check

@xl-openai xl-openai marked this pull request as ready for review June 18, 2026 06:08
@xl-openai xl-openai requested review from ericning-o and xli-oai June 18, 2026 06:09
@xl-openai xl-openai merged commit 406062c into main Jun 18, 2026
31 of 32 checks passed
@xl-openai xl-openai deleted the xl/plguins2 branch June 18, 2026 21:29
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants