Add multi-agent mode to thread settings updates#28884
Merged
shijie-oai merged 1 commit intoJun 18, 2026
Merged
Conversation
d8d7236 to
d622e4b
Compare
ae3bb59
into
shijie/ma-v2-mode-lifecycle
28 of 30 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Clients can select multi-agent mode through
thread/startandturn/start, but they cannot currently change a loaded thread's selection without starting a turn.thread/settings/updatealready exists for changing sticky next-turn settings independently of model execution, so multi-agent mode should use the same path.What changed
thread/settings/update.multiAgentModefield withexplicitRequestOnlyandproactivevalues.thread/settings/updatednotification without starting a model request or adding transcript items.Omitting
multiAgentModeleaves the loaded session's selection unchanged. As withturn/start, this API does not currently provide a distinct operation for clearing an existing selection back to unset.Verification
CARGO_INCREMENTAL=0 just test -p codex-app-server-protocolCARGO_INCREMENTAL=0 just test -p codex-app-server thread_settings_updateCARGO_INCREMENTAL=0 just test -p codex-app-server thread_settings_update_multi_agent_mode_applies_to_future_turnsCARGO_INCREMENTAL=0 just fix -p codex-app-server-protocol -p codex-app-serverjust fmtStack
Stacked on #28792, which adds thread-start initialization and lifecycle/settings observability for multi-agent mode. The underlying per-turn mode behavior is introduced in #28685.