feat(app-server): add exclusive filesystem copies#28932
Draft
nornagon-openai wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Codex Apps adapts app-server filesystem operations to its execution-host interface. Callers need an atomic copy mode that refuses to replace an existing destination and reports that condition consistently across local and remote hosts.
What
exclusivetofs/copy, defaulting tofalse.AlreadyExistsacross exec-server RPC and expose structured app-server error data as{ "code": "EEXIST" }.This PR is intentionally limited to exclusive file copies. File-size metadata and symlink semantics are independent changes.
Validation
just write-app-server-schemajust test -p codex-app-server-protocoljust test -p codex-exec-server file_system_copy_exclusive_preserves_existing_destinationjust test -p codex-app-server fs_copy_exclusive_preserves_existing_destinationjust fix -p codex-file-system -p codex-exec-server -p codex-app-server-protocol -p codex-app-serverjust fmt