[codex] Fix Windows sandbox runtime ACL refresh#28943
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 11fc8e1dfd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Codex Desktop repairs sandbox-user read/execute access for binaries copied to
%LOCALAPPDATA%\OpenAI\Codex\bin, but Computer Use launches its bundled Node runtime from%LOCALAPPDATA%\OpenAI\Codex\runtimes.On fresh Windows installations,
CodexSandboxUsersmay therefore be unable to execute the bundled Node binary. The command runner starts, butCreateProcessAsUserWfails with error 5 (ACCESS_DENIED), causing the Node REPL to exit before Computer Use can discover applications.This is a follow-up to #21564, which added the original runtime
binACL repair.What changed
binto bothbinandruntimes.Validation
cargo fmt -- --checkjust test -p codex-windows-sandboxwas run: 113 tests passed and five environment-dependent legacy execution tests failed becauseCreateRestrictedTokenreturned error 87.