[codex] Migrate skills usage guidance to model instructions#28944
Draft
ani-oai wants to merge 2 commits into
Draft
[codex] Migrate skills usage guidance to model instructions#28944ani-oai wants to merge 2 commits into
ani-oai wants to merge 2 commits into
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Collaborator
|
can you double check the token budgeting for the alias case? |
rhan-oai
reviewed
Jun 18, 2026
|
|
||
| fn body(&self) -> String { | ||
| render_available_skills_body(&[], &self.skill_lines) | ||
| render_available_skills_body(&[], &self.skill_lines, false) |
Collaborator
There was a problem hiding this comment.
why are we always passing false? doesn't this need to be aligned with the migration as well
Author
There was a problem hiding this comment.
removed the booleans with separate functions for legacy & future models -- render_legacy_available_skills_body and render_available_skills_body. Call these separately in each case.
ani-oai
force-pushed
the
codex/skills-prompt-model-guidance
branch
2 times, most recently
from
30ed120 to
73585ec
Compare
ani-oai
force-pushed
the
codex/skills-prompt-model-guidance
branch
from
73585ec to
8e315ac
Compare
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
How to use skillsguidance