Skip to content

[plugins] Add dark-mode logo metadata#28945

Open
drewschuster-openai wants to merge 1 commit into
openai:mainfrom
drewschuster-openai:drew/plugin-dark-mode-logos
Open

[plugins] Add dark-mode logo metadata#28945
drewschuster-openai wants to merge 1 commit into
openai:mainfrom
drewschuster-openai:drew/plugin-dark-mode-logos

Conversation

@drewschuster-openai

Copy link
Copy Markdown

Adds dark-mode plugin logo metadata to local manifests, remote catalog responses, and the app-server protocol.

What

  • Adds nullable logoDark and logoUrlDark fields to PluginInterface.
  • Resolves local interface.logoDark assets and maps remote logo_url_dark values.
  • Updates the bundled plugin validator and manifest reference.
  • Regenerates the app-server JSON schemas and TypeScript types.

Why

Plugin clients need both light and dark logo assets to display a readable brand mark in either theme. The new fields are additive, so clients that do not use them keep the existing logo behavior.

How

Local plugin manifests expose interface.logoDark as a package-relative asset path. Remote plugin catalog responses expose logo_url_dark. Both values map into separate app-server fields so clients can preserve local-path and remote-URL handling.

Testing

  • just test -p codex-app-server-protocol
  • just test -p codex-core-plugins
  • just test -p codex-app-server
  • just test -p codex-plugin
  • just test -p codex-skills
  • cargo build --bin codex
  • Validated a local plugin manifest containing interface.logoDark with the bundled validator.
  • Ran the required scoped just fix commands and just fmt.

Manual verification

Create a local plugin with both interface.logo and interface.logoDark, then call plugin/list or plugin/read. Confirm that the response contains separate logo and logoDark paths. For a remote catalog entry, confirm that logoUrlDark is populated from logo_url_dark.

Risk

The app-server change is additive and nullable. The main risk is an incomplete mapping path, covered by local-manifest, remote-catalog, protocol serialization, and app-server integration tests.

Spiciness: 2/5

Issue: N/A — coordinated maintainer change.

@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@drewschuster-openai drewschuster-openai marked this pull request as draft June 18, 2026 17:48

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 25013584fa

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread codex-rs/app-server-protocol/src/protocol/v2/plugin.rs
@drewschuster-openai

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

github-actions Bot added a commit that referenced this pull request Jun 18, 2026
@drewschuster-openai drewschuster-openai marked this pull request as ready for review June 18, 2026 18:34
@drewschuster-openai drewschuster-openai force-pushed the drew/plugin-dark-mode-logos branch from 2501358 to 369f989 Compare June 18, 2026 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants