[plugins] Add dark-mode logo metadata#28945
Open
drewschuster-openai wants to merge 1 commit into
Open
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 25013584fa
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Author
|
I have read the CLA Document and I hereby sign the CLA |
ericning-o
approved these changes
Jun 18, 2026
xl-openai
approved these changes
Jun 18, 2026
2501358 to
369f989
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds dark-mode plugin logo metadata to local manifests, remote catalog responses, and the app-server protocol.
What
logoDarkandlogoUrlDarkfields toPluginInterface.interface.logoDarkassets and maps remotelogo_url_darkvalues.Why
Plugin clients need both light and dark logo assets to display a readable brand mark in either theme. The new fields are additive, so clients that do not use them keep the existing logo behavior.
How
Local plugin manifests expose
interface.logoDarkas a package-relative asset path. Remote plugin catalog responses exposelogo_url_dark. Both values map into separate app-server fields so clients can preserve local-path and remote-URL handling.Testing
just test -p codex-app-server-protocoljust test -p codex-core-pluginsjust test -p codex-app-serverjust test -p codex-pluginjust test -p codex-skillscargo build --bin codexinterface.logoDarkwith the bundled validator.just fixcommands andjust fmt.Manual verification
Create a local plugin with both
interface.logoandinterface.logoDark, then callplugin/listorplugin/read. Confirm that the response contains separatelogoandlogoDarkpaths. For a remote catalog entry, confirm thatlogoUrlDarkis populated fromlogo_url_dark.Risk
The app-server change is additive and nullable. The main risk is an incomplete mapping path, covered by local-manifest, remote-catalog, protocol serialization, and app-server integration tests.
Spiciness: 2/5
Issue: N/A — coordinated maintainer change.