[plugins] Refresh plugin and tool caches after remote install#28951
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2ef0b5e562
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .into_iter() | ||
| .filter(|plugin| { | ||
| !installed_plugin_ids.contains(plugin.config_id.as_str()) | ||
| && !installed_remote_plugin_ids.contains(plugin.remote_plugin_id.as_str()) |
There was a problem hiding this comment.
could this leave the thread stuck if these two reads briefly disagree? for example, /installed could include calendar while the post-install tools/list still omits it, so we return completed: false but also filter the recommendation. do we expect the host to keep those views in sync, or should we preserve a retry path?
| @@ -1059,6 +1073,7 @@ impl PluginsManager { | |||
| .into_iter() | |||
| .filter(|plugin| { | |||
| !installed_plugin_ids.contains(plugin.config_id.as_str()) | |||
There was a problem hiding this comment.
remote plugin also has config_id right?
adaley-openai
force-pushed
the
dev/adaley/refresh-remote-plugin-tools
branch
from
2ef0b5e to
65f8415
Compare
|
/merge Sent from my Codex |
4 participants
Summary
completed: trueon every expectedapp_connector_idappearing after the uncachedtools/listrefresh, while continuing to skip local bundle verification for server-side installs.Root Cause
openai-curated-remotereturnedtruebefore taking the existing connector refresh path, leaving the resumed turn with the pre-install Apps tool catalog.Validation
just test -p codex-core request_plugin_installjust test -p codex-core-plugins recommended_plugin_candidates_filter_installed_and_disabled_pluginsjust test -p codex-core-pluginsjust fix -p codex-core-pluginsjust fix -p codex-corejust fmtjust test -p codex-corewas not fully clean locally: 2,729 passed, 26 failed, and 16 skipped. The failures were dominated by local Seatbelt/network/timing issues, including plugin-install timeouts under full-suite contention; the focused plugin-install runs pass.