core: load AGENTS.md from foreign environments#28958
Merged
Merged
Conversation
anp-oai
added a commit
that referenced
this pull request
Jun 18, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 18, 2026
anp-oai
force-pushed
the
codex/remote-windows-agents-md
branch
from
23910c7 to
73cdd64
Compare
anp-oai
force-pushed
the
codex/remote-windows-agents-md
branch
from
73cdd64 to
e1c2fd6
Compare
Collaborator
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
pakrym-oai
reviewed
Jun 18, 2026
| tracing::warn!( | ||
| "Project doc `{}` exceeds remaining budget ({} bytes) - truncating.", | ||
| p.display(), | ||
| p.inferred_native_path_string(), |
Collaborator
There was a problem hiding this comment.
nit for the future: it's cool to use real uris in logs.
Collaborator
Author
There was a problem hiding this comment.
will do as a follow-up and note it in the skill for codex
pakrym-oai
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Make it possible to load AGENTS.md from remote exec-servers whose OS is different than app-server.
What
AGENTS.mddiscovery and provenance asPathUri, with root-aware parent and ancestor traversalPathUriinternallyPathUri's parent() implementation that would erase Windows drive letters