TUI: improve unified mention selection visibility#28959
Merged
Conversation
Contributor
Author
|
@codex review |
fcoury-oai
approved these changes
Jun 18, 2026
fcoury-oai
left a comment
fcoury-oai
left a comment
Contributor
There was a problem hiding this comment.
Tested working, changes are very straightfoward. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@milanglacier reported in #28653 that the active mention candidate is hard to distinguish. I suspect @binbjz’s #28500 report (where arrow-key navigation appeared not to work) may describe the same presentation problem: the selection may have been changing, but the UI was not showing the active row clearly in their terminal. This PR makes two small changes to the selection indication behavior:
>for color-agnostic indicator coverage.Reverse-video styling was considered, but avoided it because it is overly dependent on the user’s terminal palette.
Testing
just test -p codex-tui default_unified_mention_popup_snapshotjust clippy -p codex-tuijust fmtcodex-cliand tested the unified mentions picker in the terminal.