core: bake in resize_all_images#28975
Draft
rka-oai wants to merge 1 commit into
Draft
Conversation
rka-oai
force-pushed
the
codex/always-prepare-images
branch
from
0854ab4 to
eaa5f36
Compare
rka-oai
force-pushed
the
codex/always-prepare-images
branch
from
eaa5f36 to
e264c6f
Compare
rka-oai
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resize_all_imagesdefaults tofalsein the Codex client. Desktop sends a rollout override, but CLI sessions do not, so the clients can take different image-preparation paths.Mark
resize_all_imagesas removed and enabled by default. Ignore configured values so released Desktop builds can continue sending the key without changing behavior. The existing image-preparation code is unchanged.Default-on image preparation decodes fixtures that previously passed through untouched. Replace four malformed fixtures with valid 1×1 PNGs. Tests for the retained internal disabled path now disable the feature explicitly, while the invalid-
view_imageintegration test verifies the default-on behavior.Test plan
just fmtjust test -p codex-features(53 passed)codex-coreimage, resume, compaction, Responses Lite, andview_imagetests (10 passed)