[3/3] app-server: configure environment connection timeout#29025
Merged
Conversation
pakrym-oai
reviewed
Jun 19, 2026
| environment_id: String, | ||
| exec_server_url: String, | ||
| ) -> Result<(), ExecServerError> { | ||
| self.upsert_environment_with_connect_timeout( |
Collaborator
There was a problem hiding this comment.
delete the proxy method
Collaborator
There was a problem hiding this comment.
if you need fallback make the parameter optional
pakrym-oai
approved these changes
Jun 19, 2026
d03ca11 to
dae0347
Compare
253a6ba to
bb8869d
Compare
Base automatically changed from
codex/turn-environment-starting-snapshots
to
main
June 19, 2026 05:06
dae0347 to
bd2cc5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Remote environments registered through
environment/addcurrently use the fixed 10-second WebSocket connection timeout. Slow-starting executors need a caller-selected connection window, but this should not add retry policy or couple exec-server behavior to Core’sdeferred_executorfeature.Make the timeout an optional part of the existing experimental request. Existing clients continue using the current default, while callers that know an executor may take longer can request a larger window explicitly.
Depends on #28683.
What changed
connectTimeoutMstoEnvironmentAddParamsand document it in the app-server README.EnvironmentRequestProcessorinto oneEnvironmentManager::upsert_environment()path; the manager applies the existing default when it is omitted.Test plan
just test -p codex-app-server-protocoljust test -p codex-exec-serverjust test -p codex-app-server environment_add_applies_connect_timeoutRollout
This is additive and does not enable
deferred_executor. Callers should send a non-default timeout only after a compatible app-server is deployed; omitted ornullvalues retain the existing 10-second default.