[codex] add configurable token budget compaction reminder#29255
Merged
Conversation
…rap-up-reminder # Conflicts: # codex-rs/core/src/state/auto_compact_window.rs
pakrym-oai
marked this pull request as ready for review
June 20, 2026 20:45
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a6f397cb8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…rap-up-reminder # Conflicts: # codex-rs/core/tests/suite/token_budget.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The token-budget feature reports coarse remaining-context milestones, but it does not give the model a configurable wrap-up prompt before automatic compaction. A strict threshold-crossing check can also miss resumed or reconfigured windows that are already inside the threshold.
What changed
[features.token_budget]configuration for an absolutereminder_threshold_tokensand boundedreminder_message_template;{n_remaining}is expanded when the reminder is delivered.body_after_prefixaccounting and the full context-window limit.AutoCompactWindowand re-armed on compaction,new_context, restore, or history replacement.Validation
just test -p codex-core token_budgetjust test -p codex-core token_budget_reminder_emits_after_crossing_compaction_thresholdjust test -p codex-core auto_compact_windowjust test -p codex-core lock_contains_prompts_and_materializes_featuresjust test -p codex-featuresjust test -p codex-config