code-mode: preserve dropped observation output#29288
Merged
cconger merged 1 commit intoJun 21, 2026
Merged
Conversation
cconger
force-pushed
the
cconger/code-mode-runtime-compact-03e2-observation-delivery
branch
from
June 21, 2026 06:24
f2cf22e to
78a5993
Compare
cconger
force-pushed
the
cconger/code-mode-runtime-compact-03e-shutdown-hierarchy
branch
from
June 21, 2026 06:24
0118f65 to
442d204
Compare
jif-oai
approved these changes
Jun 21, 2026
cconger
force-pushed
the
cconger/code-mode-runtime-compact-03e-shutdown-hierarchy
branch
from
June 21, 2026 19:08
442d204 to
ebc9240
Compare
cconger
force-pushed
the
cconger/code-mode-runtime-compact-03e2-observation-delivery
branch
from
June 21, 2026 19:24
78a5993 to
aeac9d7
Compare
Base automatically changed from
cconger/code-mode-runtime-compact-03e-shutdown-hierarchy
to
main
June 21, 2026 20:15
cconger
force-pushed
the
cconger/code-mode-runtime-compact-03e2-observation-delivery
branch
from
June 21, 2026 20:18
aeac9d7 to
01fa5b8
Compare
cconger
marked this pull request as ready for review
June 21, 2026 20:20
cconger
deleted the
cconger/code-mode-runtime-compact-03e2-observation-delivery
branch
June 21, 2026 20:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Canceling a wait must not consume output or a pending frontier that the caller never received.
Impact
A later observation can recover undelivered incremental output without duplication.
Validation
just test -p codex-code-mode -p codex-code-mode-protocol(70 passed).cconger/code-mode-runtime-compact-03e-shutdown-hierarchy.