Skip to content

Add a connector declaration snapshot - #29851

Merged
jif-oai merged 3 commits into
mainfrom
jif/connector-service-foundation
Jun 24, 2026
Merged

Add a connector declaration snapshot#29851
jif-oai merged 3 commits into
mainfrom
jif/connector-service-foundation

Conversation

@jif-oai

@jif-oai jif-oai commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Why

Connector declarations currently enter Codex through broad plugin capability summaries, then MCP setup, turn tooling, and app/list each reconstruct the same information. That makes executor-selected connectors difficult to add without coupling connector behavior to the host plugin loader.

This PR introduces a small connector-owned value that later stack layers can populate before thread startup.

What changed

  • Move the pure app-declaration parser into codex-connectors, preserving declaration order and category cleanup while leaving host-side validation and deduplication unchanged.
  • Add an immutable ConnectorSnapshot with ordered connector IDs and plugin display-name provenance.
  • Adapt the existing local-plugin capability summaries into that snapshot at current consumer boundaries.
  • Use the snapshot for MCP tool provenance, turn connector inventory, and app/list.
  • Keep the crate API narrow: no test-only snapshot accessors are exposed.

The externally visible behavior is unchanged. Connector tools still come from the orchestrator-owned /ps/mcp server, and local plugin enablement remains owned by the existing plugin loader.

Stack scope

This is the foundation only. It does not read selected executor packages or change thread startup. #29852 adds the executor-backed declaration reader, and #29856 composes selected declarations into a thread snapshot.

@jif-oai
jif-oai requested a review from a team as a code owner June 24, 2026 12:41

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d9c054ca19

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/connectors/Cargo.toml
@jif-oai
jif-oai merged commit 4e0f863 into main Jun 24, 2026
31 checks passed
@jif-oai
jif-oai deleted the jif/connector-service-foundation branch June 24, 2026 22:24
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants