[codex] dedupe remote control account header - #29893
Merged
Merged
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
shuo-openai
marked this pull request as ready for review
June 24, 2026 19:55
apanasenko-oai
approved these changes
Jun 24, 2026
shuo-openai
marked this pull request as draft
June 24, 2026 20:55
shuo-openai
marked this pull request as ready for review
June 24, 2026 22:05
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Remote-control HTTP requests applied the authentication headers and then appended
ChatGPT-Account-IDagain withreqwest::RequestBuilder::header. Since reqwest appends, the wire request could contain the same header twice. Intermediaries may coalesce duplicate values intouuid,uuid, which is not a valid account ID.What changed
HeaderMap::insertfor the explicit account ID. This preserves the current account-ID precedence and all other authentication headers while ensuring exactly one account header is sent.Validation
Added focused coverage for:
Checks run:
just test -p codex-app-server-transport request_headers: 3 passedjust test -p codex-app-server-transport remote_control_http_mode: 6 passedjust test -p codex-app-server-transport clients_tests: 6 passedjust test -p codex-app-server-transport: 123 passedcargo test -p codex-app-server-transport: 123 passedjust clippy -p codex-app-server-transportjust fmt-checkbazel test //codex-rs/app-server-transport:app-server-transport-unit-tests