-
Notifications
You must be signed in to change notification settings - Fork 15.7k
TUI support for buffer experience #29919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
6f6e006
365c83e
02e6292
217c2d2
63a9023
44c0918
44604a8
584b13a
9f95676
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -147,6 +147,9 @@ impl ChatWidget { | |
| ServerNotification::ModelVerification(notification) => { | ||
| self.on_app_server_model_verification(¬ification.verifications) | ||
| } | ||
| ServerNotification::ModelSafetyBufferingUpdated(notification) => { | ||
| self.on_model_safety_buffering_updated(notification, replay_kind) | ||
| } | ||
| ServerNotification::Warning(notification) => self.on_warning(notification.message), | ||
| ServerNotification::GuardianWarning(notification) => { | ||
| self.on_warning(notification.message) | ||
|
|
@@ -208,7 +211,6 @@ impl ChatWidget { | |
| | ServerNotification::ExternalAgentConfigImportProgress(_) | ||
| | ServerNotification::ExternalAgentConfigImportCompleted(_) | ||
| | ServerNotification::FsChanged(_) | ||
| | ServerNotification::ModelSafetyBufferingUpdated(_) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't have too much context on this code. What is the effect of deleting this? Will it effect the app server code that was relying on it to send to the Codex App?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This TUI was previously ignoring this notification from the app server. This line was present to ensure that the case statement was exhaustive. Our linter rules require that. The TUI is now handling this notification by calling
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah ok. Thanks for the explanation! |
||
| | ServerNotification::TurnModerationMetadata(_) | ||
| | ServerNotification::FuzzyFileSearchSessionUpdated(_) | ||
| | ServerNotification::FuzzyFileSearchSessionCompleted(_) | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.