[codex] Populate remote plugin local versions - #29956
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2dd558e9e2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Codex: plugin/installed still returns localVersion: null for remote installed plugins. In remote.rs (line 1044), group_remote_installed_plugins_by_marketplaces now constructs RemotePluginSummary with local_version: None, but this is the path used by plugin/installed via load_remote_installed_plugins. So catalog/read/share paths get the version, while installed-plugin summaries still drop it. That leaves any consumer of plugin/installed unable to resolve the materialized remote plugin root, which is the bug this PR is meant to fix. The fix likely needs to carry the installed release version through RemoteInstalledPlugin / remote_installed_plugin_to_cache_entry and assert it in a plugin_installed_* test |
385420c to
c0f6854
Compare
What
localVersion.Why
Remote plugin summaries always returned
localVersion: nulleven after their versioned bundles had been installed locally. Consumers such as scheduled-task template discovery uselocalVersionto resolve a plugin's materialized root, so templates from remote curated plugins were silently skipped.