Skip to content

[codex] Populate remote plugin local versions - #29956

Merged
abhinav-oai merged 1 commit into
mainfrom
codex/populate-remote-plugin-local-version
Jun 25, 2026
Merged

[codex] Populate remote plugin local versions#29956
abhinav-oai merged 1 commit into
mainfrom
codex/populate-remote-plugin-local-version

Conversation

@abhinav-oai

@abhinav-oai abhinav-oai commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

What

  • Carry installed remote release versions through remote plugin summaries as localVersion.
  • Keep the app-server mapping a pure adapter by populating that value in the remote catalog layer.

Why

Remote plugin summaries always returned localVersion: null even after their versioned bundles had been installed locally. Consumers such as scheduled-task template discovery use localVersion to resolve a plugin's materialized root, so templates from remote curated plugins were silently skipped.

@abhinav-oai
abhinav-oai marked this pull request as ready for review June 25, 2026 02:16

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2dd558e9e2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core-plugins/src/remote.rs
@eternal-openai

Copy link
Copy Markdown
Contributor

Codex: plugin/installed still returns localVersion: null for remote installed plugins. In remote.rs (line 1044), group_remote_installed_plugins_by_marketplaces now constructs RemotePluginSummary with local_version: None, but this is the path used by plugin/installed via load_remote_installed_plugins. So catalog/read/share paths get the version, while installed-plugin summaries still drop it. That leaves any consumer of plugin/installed unable to resolve the materialized remote plugin root, which is the bug this PR is meant to fix. The fix likely needs to carry the installed release version through RemoteInstalledPlugin / remote_installed_plugin_to_cache_entry and assert it in a plugin_installed_* test

@abhinav-oai
abhinav-oai force-pushed the codex/populate-remote-plugin-local-version branch from 385420c to c0f6854 Compare June 25, 2026 03:00
@abhinav-oai
abhinav-oai enabled auto-merge (squash) June 25, 2026 03:03
@abhinav-oai
abhinav-oai merged commit 6db9372 into main Jun 25, 2026
31 checks passed
@abhinav-oai
abhinav-oai deleted the codex/populate-remote-plugin-local-version branch June 25, 2026 03:13
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants