-
Notifications
You must be signed in to change notification settings - Fork 15.7k
[codex] Add externally provided Codex auth #31274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| use codex_login::AuthHeaders; | ||
| use codex_login::CodexAuth; | ||
| use core_test_support::responses::ev_completed; | ||
| use core_test_support::responses::ev_response_created; | ||
| use core_test_support::responses::mount_sse_once; | ||
| use core_test_support::responses::sse; | ||
| use core_test_support::responses::start_mock_server; | ||
| use core_test_support::skip_if_no_network; | ||
| use core_test_support::test_codex::test_codex; | ||
| use reqwest::header::AUTHORIZATION; | ||
| use reqwest::header::HeaderMap; | ||
| use reqwest::header::HeaderValue; | ||
|
|
||
| #[tokio::test(flavor = "multi_thread", worker_threads = 2)] | ||
| async fn header_auth_is_attached_to_responses_requests() -> anyhow::Result<()> { | ||
| skip_if_no_network!(Ok(())); | ||
|
|
||
| let server = start_mock_server().await; | ||
| let response_mock = mount_sse_once( | ||
| &server, | ||
| sse(vec![ev_response_created("resp-1"), ev_completed("resp-1")]), | ||
| ) | ||
| .await; | ||
| let mut headers = HeaderMap::new(); | ||
| headers.insert(AUTHORIZATION, HeaderValue::from_static("Bearer external")); | ||
| headers.insert("x-external-auth", HeaderValue::from_static("enabled")); | ||
| let mut builder = test_codex().with_auth(CodexAuth::Headers(AuthHeaders::new(headers))); | ||
| let test = builder.build_with_auto_env(&server).await?; | ||
|
|
||
| test.submit_turn("hello").await?; | ||
|
|
||
| let request = response_mock.single_request(); | ||
| assert_eq!( | ||
| request.header("authorization").as_deref(), | ||
| Some("Bearer external") | ||
| ); | ||
| assert_eq!( | ||
| request.header("x-external-auth").as_deref(), | ||
| Some("enabled") | ||
| ); | ||
| Ok(()) | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| use std::fmt; | ||
|
|
||
| use reqwest::header::HeaderMap; | ||
|
|
||
| /// Request headers returned by an external auth provider. | ||
| /// | ||
| /// The provider owns credential validation, rotation, and persistence. Codex | ||
| /// keeps the resolved headers in memory and attaches them to backend requests. | ||
| #[derive(Clone, PartialEq, Eq)] | ||
| pub struct AuthHeaders { | ||
| headers: HeaderMap, | ||
| } | ||
|
|
||
| impl AuthHeaders { | ||
| pub fn new(headers: HeaderMap) -> Self { | ||
| Self { headers } | ||
| } | ||
|
|
||
| pub fn headers(&self) -> &HeaderMap { | ||
| &self.headers | ||
| } | ||
| } | ||
|
|
||
| impl fmt::Debug for AuthHeaders { | ||
| fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { | ||
| f.debug_struct("AuthHeaders") | ||
| .field("headers", &"<redacted>") | ||
| .finish() | ||
| } | ||
| } |
Uh oh!
There was an error while loading. Please reload this page.