feat: add managed Bedrock login API#31327
Merged
Merged
Conversation
This was referenced Jul 7, 2026
celia-oai
force-pushed
the
codex/provider-auth-foundation
branch
from
July 7, 2026 19:17
92e0751 to
7c28baa
Compare
celia-oai
force-pushed
the
codex/managed-bedrock-api
branch
2 times, most recently
from
July 8, 2026 00:16
35ebf5d to
b16785d
Compare
celia-oai
changed the title
celia-oai
force-pushed
the
codex/managed-bedrock-api
branch
from
July 8, 2026 23:49
159f579 to
7da3ba3
Compare
Contributor
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 564b1abde2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
celia-oai
marked this pull request as ready for review
July 9, 2026 01:05
pakrym-oai
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
App-server clients can report whether Amazon Bedrock is using AWS-managed credentials or a Codex-managed API key, but they do not have a matching API for creating the managed login. This PR defines that experimental wire contract independently from its implementation.
Managed Bedrock API keys are already a primary
CodexAuthmode. The API therefore describes a normal Codex login that replaces the current stored auth rather than introducing provider-scoped credential storage.What changed
amazonBedrockvariant toaccount/login/start.experimentalApicapability.Impact
This PR defines the API shape but does not implement login behavior. The next PR adds validation, persistence through the existing Codex auth lifecycle, provider selection, and notifications.
Validation
just test -p codex-app-server-protocolStack
maincodex/managed-bedrock-apicodex/managed-bedrock-login-v2