feat(core): emit canonical review mode items - #31473
Merged
Merged
Conversation
owenlin0
force-pushed
the
owen/stable-review-event-ids
branch
from
July 7, 2026 21:43
fdb84d9 to
ec3e03c
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fdb84d94a4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
owenlin0
force-pushed
the
owen/stable-review-event-ids
branch
from
July 7, 2026 21:54
ec3e03c to
089106f
Compare
owenlin0
changed the title
owenlin0
force-pushed
the
owen/stable-review-event-ids
branch
from
July 7, 2026 22:41
089106f to
9aad937
Compare
owenlin0
changed the title
owenlin0
force-pushed
the
owen/stable-review-event-ids
branch
2 times, most recently
from
July 7, 2026 23:36
6f6cfa5 to
42b1ebe
Compare
pakrym-oai
reviewed
Jul 8, 2026
| }, | ||
| CoreTurnItem::EnteredReviewMode(review) => ThreadItem::EnteredReviewMode { | ||
| id: review.id, | ||
| review: review.user_facing_hint, |
Contributor
Author
There was a problem hiding this comment.
hmm to align the items... we need core to keep ReviewTarget / ReviewOutputEvent so we can map back to the legacy event for compatibility, so the only option is to make the app-server API thread item structured, but that's an API change which I'd like to keep out of scope for now. we can always do it later if we'd like
pakrym-oai
reviewed
Jul 8, 2026
pakrym-oai
reviewed
Jul 8, 2026
pakrym-oai
reviewed
Jul 8, 2026
| tracing = { workspace = true, features = ["log"] } | ||
| url = { workspace = true } | ||
| uuid = { workspace = true, features = ["serde", "v4", "v5"] } | ||
| uuid = { workspace = true, features = ["serde", "v4", "v5", "v7"] } |
owenlin0
force-pushed
the
owen/stable-review-event-ids
branch
from
July 8, 2026 03:16
42b1ebe to
68f5cd2
Compare
owenlin0
force-pushed
the
owen/stable-review-event-ids
branch
2 times, most recently
from
July 8, 2026 04:03
cd0a43b to
22ef76e
Compare
owenlin0
force-pushed
the
owen/stable-review-event-ids
branch
from
July 8, 2026 04:06
22ef76e to
4b6e1d8
Compare
pakrym-oai
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR moves review-mode markers onto canonical
TurnItemlifecycle:TurnItem::EnteredReviewModeTurnItem::ExitedReviewModeCore now emits
ItemStarted/ItemCompletedfor both. The completed items map back into the existingEnteredReviewMode/ExitedReviewModeevents, so raw core event consumers and legacy rollout persistence keep seeing the old events.This is the compatibility layer needed before paginated rollouts persist review markers as
ItemCompleted(TurnItem).Why
Review markers were one of the remaining app-server thread items created directly from legacy events. Giving them canonical items lets paginated history persist stable turn/item IDs without changing legacy rollouts.
What changed
TurnItems and switched review flow to emit their lifecycle.ThreadHistoryBuilderto replay canonical review items even though review turns still do not emitTurnStarted.