Skip to content

Always confirm before enabling full access - #32989

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/0ee827332441e13d9445349ed6a5a92dc8fef4b2
Jul 14, 2026
Merged

Always confirm before enabling full access#32989
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/0ee827332441e13d9445349ed6a5a92dc8fef4b2

Conversation

@copyberry

@copyberry copyberry Bot commented Jul 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Always confirm before enabling full access

Why

Full access significantly increases the risk of data loss, leaks, or unexpected behavior, so users should explicitly confirm each time they select it.

What changed

  • Always open the full access confirmation when user-reviewed approvals are active, regardless of notices.hide_full_access_warning.
  • Remove the persistent "don't ask again" option and its acknowledgement events.

Testing

  • Update the TUI permission tests and confirmation popup snapshot to cover repeated confirmation.

@shijie-oai copyberry
Always confirm before enabling full access (#32989)
d7ba5ff 
## Why

Full access significantly increases the risk of data loss, leaks, or unexpected behavior, so users should explicitly confirm each time they select it.

## What changed

- Always open the full access confirmation when user-reviewed approvals are active, regardless of `notices.hide_full_access_warning`.
- Remove the persistent "don't ask again" option and its acknowledgement events.

## Testing

- Update the TUI permission tests and confirmation popup snapshot to cover repeated confirmation.

GitOrigin-RevId: 0ee827332441e13d9445349ed6a5a92dc8fef4b2
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/0ee827332441e13d9445349ed6a5a92dc8fef4b2 branch from 042d1ff to d7ba5ff Compare July 14, 2026 06:56
@copyberry
copyberry Bot merged commit d7ba5ff into main Jul 14, 2026
11 of 26 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/0ee827332441e13d9445349ed6a5a92dc8fef4b2 branch July 14, 2026 06:57
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 14, 2026
@lffyd
lffyd temporarily deployed to issue-triage July 14, 2026 07:42 — with GitHub Actions Inactive
@lffyd
lffyd temporarily deployed to issue-triage July 14, 2026 07:42 — with GitHub Actions Inactive
@lffyd
lffyd temporarily deployed to issue-triage July 14, 2026 07:42 — with GitHub Actions Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.