Skip to content

TUI: prompt to implement plan and switch to Execute#9712

Merged
charley-oai merged 7 commits into
mainfrom
ask-to-implement-at-end-of-plan-mode
Jan 23, 2026
Merged

TUI: prompt to implement plan and switch to Execute#9712
charley-oai merged 7 commits into
mainfrom
ask-to-implement-at-end-of-plan-mode

Conversation

@charley-oai

@charley-oai charley-oai commented Jan 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replace the plan‑implementation prompt with a standard selection popup.
  • “Yes” submits a user turn in Execute via a dedicated app event to preserve normal transcript behavior.
  • “No” simply dismisses the popup.
Screenshot 2026-01-22 at 2 00 54 PM

Changes

  • Add a plan‑implementation popup using SelectionViewParams.
  • Add SubmitUserMessageWithMode so “Yes” routes through submit_user_message (ensures user history + separator state).
  • Track saw_plan_update_this_turn so the prompt appears even when only update_plan is emitted.
  • Suppress the plan popup on replayed turns, when messages are queued, or when a rate‑limit prompt is pending.
  • Add execute_mode helper for collaboration modes.
  • Add tests for replay/queued/rate‑limit guards and plan update without final message.
  • Add snapshots for both the default and “No”‑selected popup states.

@charley-oai

Copy link
Copy Markdown
Contributor Author

@codex review this

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 26ee11877a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/tui/src/chatwidget.rs Outdated

@aibrahim-oai aibrahim-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why introducing SubmitTarget? We can just send a user turn in the right mode.

@charley-oai

Copy link
Copy Markdown
Contributor Author

@codex review this

@charley-oai charley-oai marked this pull request as draft January 22, 2026 20:42
@charley-oai charley-oai force-pushed the ask-to-implement-at-end-of-plan-mode branch from e622a59 to 9d85238 Compare January 22, 2026 22:02
@charley-oai

Copy link
Copy Markdown
Contributor Author

@codex review this

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9d85238ad3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/tui/src/chatwidget.rs
@charley-oai

Copy link
Copy Markdown
Contributor Author

@codex review this

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b1f0e748b8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/tui/src/chatwidget.rs Outdated
@charley-oai

Copy link
Copy Markdown
Contributor Author

@codex review this

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b6b243fedc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/tui/src/chatwidget.rs Outdated
@charley-oai

Copy link
Copy Markdown
Contributor Author

@codex review this

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6a01bf8620

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/tui/src/chatwidget.rs
@charley-oai

Copy link
Copy Markdown
Contributor Author

@codex review this

@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Can't wait for the next one!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@charley-oai charley-oai marked this pull request as ready for review January 22, 2026 23:15
Comment thread codex-rs/tui/src/chatwidget.rs
@charley-oai charley-oai enabled auto-merge (squash) January 23, 2026 00:17
@charley-oai charley-oai merged commit 0e79d23 into main Jan 23, 2026
32 checks passed
@charley-oai charley-oai deleted the ask-to-implement-at-end-of-plan-mode branch January 23, 2026 00:25
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants