fix: #3304 skip corrupt items during pop - #3305
Merged
Merged
Conversation
Member
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
seratch
approved these changes
May 9, 2026
RudrenduPaul
pushed a commit
to RudrenduPaul/openai-agents-python
that referenced
this pull request
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pop_item()skip corrupted newest entries and continue to the next valid item.Noneonly when no valid item remains after corrupted entries are removed.PR #3247 is adjacent but only covered
MongoDBSession.pop_item()and is already merged.Test plan
uv run pytest tests/memory/test_session.py tests/extensions/memory/test_async_sqlite_session.py tests/extensions/memory/test_sqlalchemy_session.py tests/extensions/memory/test_dapr_session.py tests/extensions/memory/test_redis_session.py -k "pop_item_skips_corrupt or pop_item_returns_none_after_dropping_only_corrupt or corrupted_data_handling"uv run pytest tests/memory/test_session.py tests/extensions/memory/test_async_sqlite_session.py tests/extensions/memory/test_sqlalchemy_session.py tests/extensions/memory/test_dapr_session.py tests/extensions/memory/test_redis_session.pybash .agents/skills/code-change-verification/scripts/run.shIssue number
Closes #3304
Checks
make lintandmake format