add gitignore & remove pycache & DS_Store - #7
Closed
ryoppippi wants to merge 2 commits into
Closed
Conversation
Author
|
Related to #4 but this PR is better I think |
Collaborator
|
I'm taking care of this separately - appreciate the PR though! |
DIZ-admin
pushed a commit
to DIZ-admin/openai-agents-python
that referenced
this pull request
Nov 18, 2025
- Remove deterministic key generation from system info (security vulnerability) - Require ERNI_MASTER_KEY environment variable in production - Raise ValueError if master key not provided in production - Generate cryptographically secure random key for development only - Add clear warning that dev keys don't persist across restarts - Improve error messages with key generation instructions - Add key validation to catch format errors early Security improvements: - Prevents predictable encryption keys - Forces explicit key management in production - Provides clear guidance for secure key generation Resolves: openai#7 (CRITICAL priority) Impact: Eliminates critical security vulnerability in secret encryption
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the
openai_agentspackage, primarily focusing on removing metadata and dependencies. The most important changes include the removal of thePKG-INFOfile content, theSOURCES.txtfile content, and therequires.txtfile content..gitignoreis generated bygiboMetadata removal:
src/openai_agents.egg-info/PKG-INFO: Removed all metadata information including version, author, project URLs, classifiers, and detailed SDK usage instructions.Dependency and source file removal:
src/openai_agents.egg-info/SOURCES.txt: Removed all listed source files and test files.src/openai_agents.egg-info/requires.txt: Removed all listed dependencies includingopenai,pydantic,griffe,typing-extensions,requests, andtypes-requests.Other removals:
src/openai_agents.egg-info/dependency_links.txt: Removed the file content.src/openai_agents.egg-info/top_level.txt: Removed the top-level module nameagents.