Better naming of sub-model classes#250
Merged
dbanty merged 6 commits intoNov 24, 2020
Merged
Conversation
Contributor
Author
|
CC @dbanty |
Codecov Report
@@ Coverage Diff @@
## main #250 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 46 46
Lines 1302 1302
=========================================
Hits 1302 1302
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new naming feature for classes with parent elements in
0.7.0solves a problem for us, but the capitalization is not ideal.Currently, if the parent is "
parent" and the child is "child" it will generate classes like:After this change, it will be
Which has better capitalization. This improves naming consistency when the model/enum is in-lined under a lower-case property and proper caps can't be enforced in the specs.
Also updated is list item property naming.
Before, it was doubling the child name when naming the items of a
childlist property of aparentclass as:Now it just does