Fix 131 Incorrect Mapping for @HeadMapping/@TraceMapping/@OptionsMapping#146
Merged
hauner merged 1 commit intoSep 30, 2022
Conversation
Member
|
I usually prefer unit tests :-) It is often simpler/faster to add an integration test but annoying to track down the issue if it fails and there are no unit tests. it will go into the next release, it is not far way. :-) Thanks! |
Contributor
Author
|
Ok cool thanks for the reply. |
Member
|
released with 2022.5 :-) |
Contributor
Author
|
Great thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for the issue #131.
I added unit tests but it seems integration tests are enough. Just tell me if you want me to remove them.